Search: sync agg/aggs synonym with website-search-data#3606
Conversation
website-search-data's IndexTimeSynonyms.Docs list (essc side) added an agg/aggs -> aggregations entry and documented that it must stay in sync with docs-builder's search.yml. Add the matching synonym group and include "agg" in the fixedSynonyms subset so it is baked into the index-time analyzer (synonyms_fixed_filter) the same way esql, data-stream(s), and machine-learning already are. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Label error. Requires exactly 1 of: automation, breaking, bug, changelog:skip, chore, ci, dependencies, documentation, enhancement, feature, fix, redesign. Found: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis change adds "agg" as a new synonym mapping to "aggregations" in the search configuration file, and correspondingly updates the hardcoded fixed synonyms list in the Elasticsearch exporter's constructor to include "agg", ensuring consistency between the search-time synonym configuration and the index-time synonym set baked into the search index analyzer. Related PRs: None specified Suggested labels: search, config Suggested reviewers: None specified 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
agg/aggs => aggregationssynonym group toconfig/search.yml, matching the entry website-search-data'sIndexTimeSynonyms.Docslist now expects."agg"to thefixedSynonymssubset inElasticsearchMarkdownExporter, so the group is baked into the index-time analyzer (synonyms_fixed_filter) the same wayesql,data-stream(s), andmachine-learningalready are, rather than only landing in the updateable search-time set.Coordinated with the parallel relevance work in
elastic/website-search-data(commite6cfa72), whoseIndexTimeSynonyms.Docscomment explicitly calls out staying in sync with this file.Test plan
dotnet build src/Elastic.Markdownsucceedsdotnet format/ lint clean (pre-push hook passed)esql, data-stream, data-streams, machine-learning, agg) matchesIndexTimeSynonyms.Docsin website-search-data byte-for-byte before reindexing