Skip to content

Search: sync agg/aggs synonym with website-search-data#3606

Open
Mpdreamz wants to merge 1 commit into
mainfrom
relevance/synonym-sync
Open

Search: sync agg/aggs synonym with website-search-data#3606
Mpdreamz wants to merge 1 commit into
mainfrom
relevance/synonym-sync

Conversation

@Mpdreamz

@Mpdreamz Mpdreamz commented Jul 2, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds an agg/aggs => aggregations synonym group to config/search.yml, matching the entry website-search-data's IndexTimeSynonyms.Docs list now expects.
  • Adds "agg" to the fixedSynonyms subset in ElasticsearchMarkdownExporter, so the group is baked into the index-time analyzer (synonyms_fixed_filter) the same way esql, data-stream(s), and machine-learning already are, rather than only landing in the updateable search-time set.

Coordinated with the parallel relevance work in elastic/website-search-data (commit e6cfa72), whose IndexTimeSynonyms.Docs comment explicitly calls out staying in sync with this file.

Test plan

  • dotnet build src/Elastic.Markdown succeeds
  • dotnet format / lint clean (pre-push hook passed)
  • Confirm the derived index-time synonym list (esql, data-stream, data-streams, machine-learning, agg) matches IndexTimeSynonyms.Docs in website-search-data byte-for-byte before reindexing

website-search-data's IndexTimeSynonyms.Docs list (essc side) added an
agg/aggs -> aggregations entry and documented that it must stay in
sync with docs-builder's search.yml. Add the matching synonym group
and include "agg" in the fixedSynonyms subset so it is baked into
the index-time analyzer (synonyms_fixed_filter) the same way esql,
data-stream(s), and machine-learning already are.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@Mpdreamz Mpdreamz requested a review from a team July 2, 2026 19:10
@Mpdreamz Mpdreamz requested a review from a team as a code owner July 2, 2026 19:10
@Mpdreamz Mpdreamz requested a review from reakaleek July 2, 2026 19:10
@Mpdreamz Mpdreamz temporarily deployed to integration-tests July 2, 2026 19:10 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Label error. Requires exactly 1 of: automation, breaking, bug, changelog:skip, chore, ci, dependencies, documentation, enhancement, feature, fix, redesign. Found:

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 3a507466-6af6-4a78-a6f7-990c4ccf2004

📥 Commits

Reviewing files that changed from the base of the PR and between f3410ff and 8cea1b8.

📒 Files selected for processing (2)
  • config/search.yml
  • src/Elastic.Markdown/Exporters/Elasticsearch/ElasticsearchMarkdownExporter.cs

📝 Walkthrough

Walkthrough

This change adds "agg" as a new synonym mapping to "aggregations" in the search configuration file, and correspondingly updates the hardcoded fixed synonyms list in the Elasticsearch exporter's constructor to include "agg", ensuring consistency between the search-time synonym configuration and the index-time synonym set baked into the search index analyzer.

Related PRs: None specified

Suggested labels: search, config

Suggested reviewers: None specified

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: keeping the agg/aggs synonym in sync with website-search-data.
Description check ✅ Passed The description is directly related to the synonym sync changes and explains the intent and test plan.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch relevance/synonym-sync

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant