Skip to content

perf: added teak support#38

Merged
Asespinel merged 6 commits into
mainfrom
ase/added-teak-support
Jun 23, 2025
Merged

perf: added teak support#38
Asespinel merged 6 commits into
mainfrom
ase/added-teak-support

Conversation

@Asespinel

@Asespinel Asespinel commented Jun 22, 2025

Copy link
Copy Markdown
Contributor

Description

This PR aims to support the Teak release.

Testing instructions

1, Create a Teak environment using Tutor or TVM.
2. Install xblock-mindmap using this branch you can follow the official tutor documentation.
3. In a course of study:
Navigate to Settings -> Advanced Settings and go to Advanced Module List settings.
Add: "mindmap"
4. Add the component under the "advanced" section
5.
image

@Asespinel Asespinel requested a review from a team as a code owner June 22, 2025 22:02

@magajh magajh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Asespinel please remember to update the CHANGELOG

Also, have we checked that all the dependencies of the workflows are up to date?

Comment thread README.rst Outdated
The settings can be changed in ``mindmap/settings/common.py`` or, for example, in tutor configurations.

**NOTE**: the current ``common.py`` works with Open edX Palm, Quince, Redwood and Sumac versions.
**NOTE**: the current ``common.py`` works with Open edX Palm, Quince, Redwood, Sumac and Teak versions.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the change log and the readme file.

Comment thread mindmap/__init__.py Outdated
urllib3<2.0.0
# Cause: https://github.com/openedx/edx-lint/issues/475
# This can be unpinned once https://github.com/openedx/edx-lint/issues/476 has been resolved.
urllib3<2.3.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the xblocks have problems if we remove this constraint?

@magajh magajh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small comment regarding the changelog entry

Comment thread CHANGELOG.rst Outdated
Changed
=======

* Updated dependency versions in requirements

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should improve this entry

@Asespinel Asespinel merged commit 0e5dd0b into main Jun 23, 2025
1 check passed
@Asespinel Asespinel deleted the ase/added-teak-support branch June 23, 2025 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants