Don't log expected exceptions#1441
Open
ptziegler wants to merge 1 commit into
Open
Conversation
Test Results 4 files ±0 4 suites ±0 2h 22m 36s ⏱️ +3s For more details on these failures and errors, see this check. Results for commit 7b7100d. ± Comparison against base commit 3bcccfd. ♻️ This comment has been updated with latest results. |
ptziegler
force-pushed
the
expected-exceptions
branch
3 times, most recently
from
b27d525 to
68d8e85
Compare
ptziegler
force-pushed
the
expected-exceptions
branch
from
68d8e85 to
8a5464c
Compare
Some tests deliberately throw an exception. These exceptions are expected and should not show up in the build log. Logging can already be disabled by calling `setDisplayExceptionOnConsole(...)`. If disabled, this flag will now prevent any propagation to the console.
ptziegler
force-pushed
the
expected-exceptions
branch
from
8a5464c to
7b7100d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tests deliberately throw an exception. These exceptions are expected and should not show up in the build log. Logging can already be disabled by calling
setDisplayExceptionOnConsole(...). If disabled, this flag will now prevent any propagation to the console.