Skip to content

[2303] Add support for list item inheritance in states and exhibit states compartments#2304

Open
gcoutable wants to merge 1 commit into
mainfrom
gco/enh/states-compartment-inherited
Open

[2303] Add support for list item inheritance in states and exhibit states compartments#2304
gcoutable wants to merge 1 commit into
mainfrom
gco/enh/states-compartment-inherited

Conversation

@gcoutable

@gcoutable gcoutable commented Jun 24, 2026

Copy link
Copy Markdown
Member
  • [2303] Add support for list item inheritance in states and exhibit states compartments

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

  • Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@gcoutable gcoutable added this to the 2026.7.0 milestone Jun 24, 2026
@gcoutable gcoutable changed the base branch from main to gco/enh/actions-compartment-inherited June 24, 2026 13:50
@gcoutable gcoutable force-pushed the gco/enh/states-compartment-inherited branch from 191b515 to f003a8c Compare June 24, 2026 13:57
@AxelRICHARD AxelRICHARD force-pushed the gco/enh/actions-compartment-inherited branch from 3b0e8c3 to 1ac5e58 Compare June 25, 2026 09:11
Base automatically changed from gco/enh/actions-compartment-inherited to main June 25, 2026 11:23
@gcoutable gcoutable force-pushed the gco/enh/states-compartment-inherited branch from f003a8c to 30e4b43 Compare June 25, 2026 14:56
…ates compartments

Bug: #2303
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
@gcoutable gcoutable force-pushed the gco/enh/states-compartment-inherited branch from 30e4b43 to bf7f83d Compare June 25, 2026 15:00
@gcoutable gcoutable marked this pull request as ready for review June 25, 2026 15:00
* <li>Applies the tool {@code specializationToolName} to create a specialization relationship between the created node and the base element</li>
* </ol>
*/
private final class ElementSpecializationInheritanceChecker {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please extract that in a separate file, probably in backend/views/syson-diagram-tests/src/main/java/org/eclipse/syson/diagram/tests/checkers

}

@Override
public Boolean caseExhibitStateUsage(ExhibitStateUsage object) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add this case just after caseConstraintUsage to respect the alphabetical order

*/
public class InheritedCompartmentItemFilterSwitch extends SysmlSwitch<Boolean> {

private final Type type;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please explain what is this class attribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for list item inheritance in states and exhibit states compartments

2 participants