Improve FullProf verification intensity agreement#218
Open
AndrewSazonov wants to merge 10 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #218 +/- ##
===========================================
+ Coverage 82.26% 90.34% +8.08%
===========================================
Files 88 284 +196
Lines 5451 24664 +19213
Branches 454 2897 +2443
===========================================
+ Hits 4484 22282 +17798
- Misses 802 1756 +954
- Partials 165 626 +461
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FullProf verification examples now use the corrected occupancy convention and refreshed reference outputs, making intensity comparisons with EasyDiffraction more reliable. Examples that now agree directly no longer apply unnecessary scale fitting, including the Fe time-of-flight pseudo-Voigt case. The documentation also links against the fixed EasyScience Core 2.3.1 API inventory so reference pages resolve consistently.