Skip to content

Add admin command tests for logRotate#642

Open
vic-tsang wants to merge 1 commit into
documentdb:mainfrom
vic-tsang:admin/commands/logRotate/test
Open

Add admin command tests for logRotate#642
vic-tsang wants to merge 1 commit into
documentdb:mainfrom
vic-tsang:admin/commands/logRotate/test

Conversation

@vic-tsang

@vic-tsang vic-tsang commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

This PR contains:

  • admin command tests for logRotate
  • execute_admin_with_retry_command: added a retry mechanism for execute_admin_command. Without the retry mechanism, the first test would be pass but subsequent tests would fail.

Background:

  • When logRotate runs, it renames the active log file to an archive name built from the
    current timestamp with one-second resolution, e.g. my_server_log.2026-06-24T17-18-27. The rename target is fully determined by the wall-clock second.
  • If two rename happens within the same second, they would both have the same name and one of the rename will fail.

Discussion Points:

  • Audit log is skipped as it needs a special flag for the server. Please let me know if it worthwhile to enable for one test case.

Ref:

Signed-off-by: Victor [C] Tsang <vitsangp@amazon.com>
@vic-tsang vic-tsang requested a review from a team as a code owner June 24, 2026 17:14
@documentdb-triage-tool documentdb-triage-tool Bot added compatibility test Compatibility test related enhancement New feature or request labels Jun 24, 2026
@documentdb-triage-tool

Copy link
Copy Markdown

🤖 Auto-triaged by documentdb-triage-tool.

Applied: compatibility test, enhancement
Project fields suggested: Component test-coverage · Priority P2 · Effort L · Status Needs Review
Confidence: 0.30 (deterministic)

Reasoning

component from path globs (test-coverage, test-framework); effort from diff stats (263+10 LOC, 10 files); LLM failed: Invalid response body while trying to fetch https://api.anthropic.com/v1/messages: Premature close

If a label is wrong, remove it manually and ping @patty-chow so the rules can be tuned. The bot will not re-label items that already have component labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compatibility test Compatibility test related enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant