Add fsyncUnlock command tests#641
Open
danielfrankcom wants to merge 4 commits into
Open
Conversation
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
documentdb-triage-tool
Bot
added
compatibility test
|
🤖 Auto-triaged by documentdb-triage-tool. Applied: Reasoningcomponent from path globs (test-framework, test-coverage); effort from diff stats (403+2 LOC, 3 files); LLM: Adds new test coverage for the fsyncUnlock command in the compatibility test suite, a straightforward test addition. If a label is wrong, remove it manually and ping |
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Upstream's declarative-environments rework (documentdb#617) replaced the single config.connection_string attribute with per-target parametrization, exposing the current target's string via the connection_string fixture. The merge left test_fsyncUnlock_releases_lock_taken_on_another_connection reading pytestconfig.connection_string, which no longer exists and fails at runtime with AttributeError on every target. Take the second client's connection string from the connection_string fixture instead. Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
tonglyu
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds tests for the
fsyncUnlockadministration command.This command affects global state, so it uses the
no_parallelmark, and also has anautousefixture which makes sure we have a clean state before running each test.Closes #421