Add admin command tests for getParameter#634
Conversation
Signed-off-by: Victor [C] Tsang <vitsangp@amazon.com>
vic-tsang
force-pushed
the
admin/commands/getParameter/tests
branch
from
82a5786 to
ed7d83e
Compare
|
🤖 Auto-triaged by documentdb-triage-tool. Applied: Reasoningcomponent from path globs (test-coverage); effort from diff stats (649+0 LOC, 4 files); LLM: Adds new test coverage for the getParameter admin command, a focused addition to the compatibility test suite. If a label is wrong, remove it manually and ping |
documentdb-triage-tool
Bot
added
compatibility test
| @@ -0,0 +1,345 @@ | |||
| """Tests for getParameter command core behavior.""" | |||
|
|
|||
There was a problem hiding this comment.
Missing: What happens when {allParameters: true} and a named parameter are both specified? E.g., {"getParameter": {"allParameters": True}, "logLevel": 1}. In MongoDB this returns all parameters (the named param is ignored). Worth testing to confirm DocumentDB matches.
| @@ -0,0 +1,161 @@ | |||
| """Tests for getParameter command error cases.""" | |||
|
|
|||
There was a problem hiding this comment.
Missing: setAt: "" (empty string). "invalid" is tested for BadValue, but empty string is a distinct
boundary — it may pass string type validation but fail value validation differently, or be treated as
"no filter" on some implementations.
| @@ -0,0 +1,345 @@ | |||
| """Tests for getParameter command core behavior.""" | |||
There was a problem hiding this comment.
Other command test files in this repo include a @pytest.mark.smoke test for the happy path. Consider adding one:
2 participants
This PR contains:
Ref: