#1965: improve dependent installations#2016
Conversation
Coverage Report for CI Build 27610519697Coverage increased (+0.03%) to 71.313%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats💛 - Coveralls |
laert-ll
left a comment
There was a problem hiding this comment.
I want to make sure I understand the scope correctly: the issue description gave me the impression that the fix was supposed to be on a bigger scale (using the parent install request so loops get detected on their own). So is it intentional to use the skipInstallation as a workaround or am I missing something?
Also it might be a good idea to add some tests for this as well.
Everything works well, the issue is solved in a simple way and removes the problem, thanks for your work!
There was a problem hiding this comment.
Is there any particular reason why Pip doesn't override isSkipInstallation() in the same way that Npm does?
There was a problem hiding this comment.
because i didn't found a loop dependency that can occurs in pip context.
There was a problem hiding this comment.
regarding tests i will add some junit tests in NgTest and NestTest
This PR fixes #1965
Implemented changes:
NpmBasedCommandletinstalled-version checks now callrunPackageManager(request, true)which preventsnpm list -g <package> --depth=0from recursively triggeringnpm.install.PipBasedCommandletTesting instructions
For the test you can use Intellij directly by running
com.devonfw.tools.ide.cli.Ideasywithinstall <Tool>as arguments or using GraalVM and the call the created ideasy.exe withinstall <Tool>Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal