test: add target migration precheck#2500
Open
eofff wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a dedicated e2e precheck label for TargetMigration tests.
The new precheck verifies that the TargetMigration feature accepts
VirtualMachineOperation.spec.migrate.nodeSelectorvia dry-run creation and checks that at least two ready KVM-enabled worker nodes are available before running the target migration e2e scenario.Why do we need it, and what problem does it solve?
Target migration e2e tests require both the TargetMigration feature and enough suitable worker nodes. Without a dedicated precheck, the test can fail later with less actionable errors when the environment does not satisfy these requirements.
What is the expected result?
TargetMigration e2e tests are skipped or fail early with a clear precheck message when the required feature or worker nodes are unavailable. The precheck can be disabled with
TARGET_MIGRATION_PRECHECK=no.Checklist