Skip to content

fix(swift-example-app): fix compile timeout on on newest xcode versions#3899

Open
ZocoLini wants to merge 1 commit into
v3.1-devfrom
fix/example-app-str-concat
Open

fix(swift-example-app): fix compile timeout on on newest xcode versions#3899
ZocoLini wants to merge 1 commit into
v3.1-devfrom
fix/example-app-str-concat

Conversation

@ZocoLini

@ZocoLini ZocoLini commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

The newest version of the compiler can't analyze the String concatenation without timing out

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Summary by CodeRabbit

  • Refactor
    • Improved code organization in the identity creation form by simplifying the funding source section.

@thepastaclaw

thepastaclaw commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

✅ Review complete (commit 3655d13)

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The inline conditional string construction for the "Funding Source" section footer in CreateIdentityView was extracted into a new static helper function fundingSourceFooterText(showShielded:). The footer now calls this helper instead of building the string inline.

Changes

Footer Text Extraction

Layer / File(s) Summary
Extract fundingSourceFooterText helper
packages/swift-sdk/SwiftExampleApp/SwiftExampleApp/Views/CreateIdentityView.swift
Inline conditional footer string construction replaced with a call to a new static helper fundingSourceFooterText(showShielded:); footer renders Text(Self.fundingSourceFooterText(showShielded: showShielded)).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A string once sprawled across the view,
Now tucked in a helper, neat and new.
🐇 The rabbit refactored with a hop,
One function call — and then a stop.
Clean code blooms where inline tangles drop!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically identifies that the PR fixes a compile timeout issue in the Swift example app on newest Xcode versions, which directly matches the main change of refactoring string concatenation to resolve compiler analysis timeout.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/example-app-str-concat

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Trivial single-file SwiftUI refactor that extracts inline conditional footer string construction in CreateIdentityView into a static helper to work around a Swift type-checker timeout on newer Xcode versions. The output string is semantically identical across both branches of the showShielded conditional, and no agent or CodeRabbit findings were raised. Verified diff against HEAD.

@github-actions

Copy link
Copy Markdown
Contributor

✅ DashSDKFFI.xcframework built for this PR.

SwiftPM (host the zip at a stable URL, then use):

.binaryTarget(
  name: "DashSDKFFI",
  url: "https://your.cdn.example/DashSDKFFI.xcframework.zip",
  checksum: "c7e933543afe5c7c8093cadb7fec3dc411f44b41cbd9f53fb792c3523d8992d2"
)

Xcode manual integration:

  • Download 'DashSDKFFI.xcframework' artifact from the run link above.
  • Drag it into your app target (Frameworks, Libraries & Embedded Content) and set Embed & Sign.
  • If using the Swift wrapper package, point its binaryTarget to the xcframework location or add the package and place the xcframework at the expected path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants