fix(swift-example-app): fix compile timeout on on newest xcode versions#3899
fix(swift-example-app): fix compile timeout on on newest xcode versions#3899ZocoLini wants to merge 1 commit into
Conversation
|
✅ Review complete (commit 3655d13) |
📝 WalkthroughWalkthroughThe inline conditional string construction for the "Funding Source" section footer in ChangesFooter Text Extraction
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
thepastaclaw
left a comment
There was a problem hiding this comment.
Code Review
Trivial single-file SwiftUI refactor that extracts inline conditional footer string construction in CreateIdentityView into a static helper to work around a Swift type-checker timeout on newer Xcode versions. The output string is semantically identical across both branches of the showShielded conditional, and no agent or CodeRabbit findings were raised. Verified diff against HEAD.
|
✅ DashSDKFFI.xcframework built for this PR.
SwiftPM (host the zip at a stable URL, then use): .binaryTarget(
name: "DashSDKFFI",
url: "https://your.cdn.example/DashSDKFFI.xcframework.zip",
checksum: "c7e933543afe5c7c8093cadb7fec3dc411f44b41cbd9f53fb792c3523d8992d2"
)Xcode manual integration:
|
The newest version of the compiler can't analyze the String concatenation without timing out
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit