-
Notifications
You must be signed in to change notification settings - Fork 1
Test rust 4 #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Test rust 4 #56
Changes from all commits
f46a6f2
98cb22d
8fd5a8f
356d61a
6609051
8e685fa
93ef4e0
0fa4be8
2f7cee7
1a40e9c
d380674
648dcaa
9fdf912
18c460c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| --- | ||
| Language: Cpp | ||
| BasedOnStyle: WebKit | ||
| BasedOnStyle: WebKit |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -182,3 +182,4 @@ CheckOptions: | |
| value: '1' | ||
| - key: readability-uppercase-literal-suffix.NewSuffixes | ||
| value: '' | ||
| ... | ||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,17 +1,18 @@ | ||||||||||||||||||||||||||||
| /** This is a very ugly test code (doomed to fail linting) */ | ||||||||||||||||||||||||||||
| #include "demo.hpp" | ||||||||||||||||||||||||||||
| #include <cstdio> | ||||||||||||||||||||||||||||
| #include <cstddef> | ||||||||||||||||||||||||||||
| #include <stdio.h> | ||||||||||||||||||||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. clang-tidy diagnostic(s)
Suggested change
|
||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| // using size_t from cstddef | ||||||||||||||||||||||||||||
| size_t dummyFunc(size_t i) { return i; } | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| int main() | ||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||
| for (;;) | ||||||||||||||||||||||||||||
| break; | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| int main(){ | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| for (;;) break; | ||||||||||||||||||||||||||||
|
Comment on lines
5
to
+10
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. clang-tidy diagnostic(s)
Suggested change
|
||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| printf("Hello world!\n"); | ||||||||||||||||||||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. clang-tidy diagnosticsrc/demo.cpp:13:5 warning: [cppcoreguidelines-pro-type-vararg]
13 | printf("Hello world!\n");
| ^ |
||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| return 0; | ||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
|
Comment on lines
14
to
+17
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. clang-tidy suggestion
Suggested change
|
||||||||||||||||||||||||||||
| return 0;} | ||||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -5,12 +5,10 @@ | |||||||||||||
| class Dummy { | ||||||||||||||
| char* useless; | ||||||||||||||
| int numb; | ||||||||||||||
|
Comment on lines
5
to
7
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. clang-tidy diagnostic(s)
Suggested change
|
||||||||||||||
| Dummy() :numb(0), useless("\0"){} | ||||||||||||||
|
|
||||||||||||||
| public: | ||||||||||||||
|
Comment on lines
9
to
10
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. clang-tidy suggestion
Suggested change
|
||||||||||||||
| void *not_usefull(char *str){ | ||||||||||||||
| useless = str; | ||||||||||||||
| return 0; | ||||||||||||||
| } | ||||||||||||||
| void *not_useful(char *str){useless = str;} | ||||||||||||||
| }; | ||||||||||||||
|
|
||||||||||||||
|
|
||||||||||||||
|
|
@@ -28,14 +26,11 @@ class Dummy { | |||||||||||||
|
|
||||||||||||||
|
|
||||||||||||||
|
|
||||||||||||||
|
|
||||||||||||||
|
|
||||||||||||||
|
|
||||||||||||||
|
|
||||||||||||||
|
|
||||||||||||||
|
|
||||||||||||||
| struct LongDiff | ||||||||||||||
| { | ||||||||||||||
|
|
||||||||||||||
| long diff; | ||||||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. clang-tidy suggestionPlease remove the line(s)
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it is supposed to say line 33 not 34 here. I need to investigate. For some reason, this logic is not covered in the tests.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It may supposed to be line 35. The diff logic uses a zero-based counting, and the line numbers from that logic are never offset (+1) for human comprehension. |
||||||||||||||
|
|
||||||||||||||
| }; | ||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy diagnostic(s)