fix(gui): preserve filepath in apply error state#12882
Open
Manpreet2298 wants to merge 1 commit into
Open
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #12641
Preserve the original
filepathwhen an edit/apply operation fails in the GUI apply flow.Previously, the failure path in
handleApplyStateUpdatecould close the apply state without carrying the file path forward, which caused the UI to showFailed to edit undefined.This change keeps the file context in the error flow so the failure message references the correct file.
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
Not applicable for this change, since this is a minimal error-state handling fix.
Tests
No tests were added as part of this minimal fix.
The change is limited to preserving
filepathin the failed apply-state update so the existing error message uses the correct file path instead ofundefined.Summary by cubic
Preserve the original
filepathin the GUI apply error flow so failure messages show the correct file. Fixes "Failed to edit undefined" by carryingfilepaththrough the failed apply-state update.Written for commit fd245dc. Summary will update on new commits.