Skip to content

fix(search): ignore blank queries for name bonus #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jiangyq9 wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −1
Open

fix(search): ignore blank queries for name bonus #1008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion __tests__/context-ranking.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import * as path from 'path';
import * as os from 'os';
import CodeGraph from '../src/index';
import { LOW_CONFIDENCE_MARKER } from '../src/context';
import { isDistinctiveIdentifier, scorePathRelevance, deriveProjectNameTokens } from '../src/search/query-utils';
import { isDistinctiveIdentifier, nameMatchBonus, scorePathRelevance, deriveProjectNameTokens } from '../src/search/query-utils';

describe('isDistinctiveIdentifier', () => {
it('treats plain dictionary words as non-distinctive', () => {
Expand All @@ -39,6 +39,13 @@ describe('isDistinctiveIdentifier', () => {
});
});

describe('nameMatchBonus', () => {
it('does not award a name match bonus for empty or whitespace-only queries', () => {
expect(nameMatchBonus('Anything', '')).toBe(0);
expect(nameMatchBonus('Anything', ' \n\t ')).toBe(0);
});
});

// A single PascalCase query word (notably a project name a user naturally
// includes) splits into sub-tokens that all match the SAME path segment; summed
// per sub-token it boosted that path 4×, burying the rest of the query's stack
Expand Down
2 changes: 2 additions & 0 deletions src/search/query-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,8 @@ function matchesNonProductionDir(lowerPath: string): boolean {
export function nameMatchBonus(nodeName: string, query: string): number {
const nameLower = nodeName.toLowerCase();

if (query.trim().length === 0) return 0;

// Split query into word-level terms (handles "CacheBuilder build" → ["cache","builder","build"])
const rawTerms = query
.replace(/([a-z])([A-Z])/g, '$1 $2')
Expand Down