Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 35 additions & 1 deletion __tests__/db-perf.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import * as path from 'path';
import * as os from 'os';
import { DatabaseConnection } from '../src/db';
import { QueryBuilder } from '../src/db/queries';
import { Node } from '../src/types';
import { Node, UnresolvedReference } from '../src/types';

function makeNode(id: string, name = id): Node {
return {
Expand Down Expand Up @@ -174,6 +174,40 @@ describe('insertEdges endpoint validation', () => {
});
});

describe('deleteResolvedReferences', () => {
let dir: string;
let db: DatabaseConnection;
let q: QueryBuilder;

beforeEach(() => {
dir = fs.mkdtempSync(path.join(os.tmpdir(), 'db-perf-delete-refs-'));
db = DatabaseConnection.initialize(path.join(dir, 'test.db'));
q = new QueryBuilder(db.getDb());
});

afterEach(() => {
db.close();
if (fs.existsSync(dir)) fs.rmSync(dir, { recursive: true, force: true });
});

it('handles batches over the SQLite parameter limit when deleting resolved refs', () => {
q.insertNodes(Array.from({ length: 1500 }, (_, i) => makeNode(`n${i}`)));
const refs: UnresolvedReference[] = Array.from({ length: 1500 }, (_, i) => ({
fromNodeId: `n${i}`,
referenceName: `target${i}`,
referenceKind: 'calls',
line: 1,
column: 0,
filePath: 'a.ts',
language: 'typescript',
}));
q.insertUnresolvedRefsBatch(refs);

expect(() => q.deleteResolvedReferences(refs.map((ref) => ref.fromNodeId))).not.toThrow();
expect(q.getUnresolvedReferencesCount()).toBe(0);
});
});

describe('runMaintenance', () => {
let dir: string;
let db: DatabaseConnection;
Expand Down
7 changes: 5 additions & 2 deletions src/db/queries.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1731,8 +1731,11 @@ export class QueryBuilder {
*/
deleteResolvedReferences(fromNodeIds: string[]): void {
if (fromNodeIds.length === 0) return;
const placeholders = fromNodeIds.map(() => '?').join(',');
this.db.prepare(`DELETE FROM unresolved_refs WHERE from_node_id IN (${placeholders})`).run(...fromNodeIds);
for (let i = 0; i < fromNodeIds.length; i += SQLITE_PARAM_CHUNK_SIZE) {
const chunk = fromNodeIds.slice(i, i + SQLITE_PARAM_CHUNK_SIZE);
const placeholders = chunk.map(() => '?').join(',');
this.db.prepare(`DELETE FROM unresolved_refs WHERE from_node_id IN (${placeholders})`).run(...chunk);
}
}

/**
Expand Down