Add class registering way of registering stuff#21
Merged
Conversation
nicosammito
requested changes
Apr 7, 2026
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/development/hercules/-/pipelines/2612334767 Status: Passed Job summariesdocs:previewDocumentation preview available at https://code0-tech.gitlab.io/-/development/telescopium/-/jobs/14927517336/artifacts/out/index.html |
Knerio
force-pushed
the
20-add-new-way-of-registering-functions
branch
from
d25c501 to
52d7868
Compare
nicosammito
requested changes
Apr 10, 2026
nicosammito
left a comment
nicosammito
left a comment
Member
There was a problem hiding this comment.
The sdk is in generally really confusing and it's hard to understand what and when something is happening.
| @@ -0,0 +1,18 @@ | |||
| import { defineConfig } from 'vite'; | |||
| import {registerRuntimeFunctionDefinitionClass} from "./builder/registerRuntimeFunctionDefinitionClass"; | ||
|
|
||
|
|
||
| const createSdk = (config: ActionSdk["config"], configDefinitions?: HerculesActionConfigurationDefinition[]): ActionSdk => { |
Member
There was a problem hiding this comment.
Why not using EventEmitter in general for js based communication?
Knerio
force-pushed
the
20-add-new-way-of-registering-functions
branch
2 times, most recently
from
f2ffbcf to
8719635
Compare
Co-authored-by: Nico Sammito <nsammito@code0.tech> Signed-off-by: Dario Pranjic <96529060+Knerio@users.noreply.github.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
nicosammito
force-pushed
the
20-add-new-way-of-registering-functions
branch
from
3641622 to
53d90c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #20