Skip to content

chore(deps): upgrade cipherstash-client to 0.38.0, drop vendored stack-auth patch (CIP-3233)#409

Open
freshtonic wants to merge 1 commit into
mainfrom
james/cip-3233-proxy-drop-vendor-patch
Open

chore(deps): upgrade cipherstash-client to 0.38.0, drop vendored stack-auth patch (CIP-3233)#409
freshtonic wants to merge 1 commit into
mainfrom
james/cip-3233-proxy-drop-vendor-patch

Conversation

@freshtonic

@freshtonic freshtonic commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Summary

Moves Proxy off the vendor/stack-auth [patch.crates-io] workaround and onto the current released cipherstash-client group, built against the fixed stack-auth. This is the CIP-3233 follow-up cleanup.

Background: 2.2.4 (#408) shipped the CIP-3233 access-key token-refresh fix via a vendored stack-auth, patched on top of the 0.34.1-alpha.4 source that cipherstash-client 0.34.1-alpha.4 pinned. cipherstash-client 0.38.0 links stack-auth 0.38.0, which carries the same fix straight from crates.io — so the vendored copy and the patch are no longer needed.

Changes

  • cipherstash-client / cipherstash-config / cts-common: 0.34.1-alpha.40.38.0 (the current published group). The API migration for the 0.34 → 0.37 jump is carried over from the (closed) feat: upgrade cipherstash-client to 0.37.0 #406 0.37.0 upgrade — same 10 source-file changes; 0.37 → 0.38 needed no further source changes.
  • Removed [patch.crates-io] stack-auth = { path = "vendor/stack-auth" }, the exclude = ["vendor/stack-auth"] workspace entry, and the entire vendor/stack-auth/ tree.
  • stack-auth now resolves from crates.io at 0.38.0 (registry source, verified in the lock). Single version of the whole cipherstash-client group; zerokms-protocol at 0.12.19.

Verification

  • cargo check --workspace — clean
  • cargo clippy --workspace --all-targets — clean
  • cargo test --workspace --lib111 cipherstash-proxy unit tests pass
  • Lock contains exactly one stack-auth (0.38.0, registry source); no vendor/ or patch.crates-io references remain

Not run: cipherstash-proxy-integration tests (need a live Postgres + ZeroKMS; they fail here only with ConnectionRefused). Please run the full integration suite in CI / with creds before merge.

Notes

Closes the cipherstash/proxy follow-up line item on CIP-3233.

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@freshtonic, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 42 minutes and 22 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e8fe116e-1404-4569-bd67-26c9e3e22fdf

📥 Commits

Reviewing files that changed from the base of the PR and between 4facf29 and 2e11f69.

⛔ Files ignored due to path filters (2)
  • Cargo.lock is excluded by !**/*.lock
  • vendor/stack-auth/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (33)
  • Cargo.toml
  • packages/cipherstash-proxy/src/error.rs
  • packages/cipherstash-proxy/src/lib.rs
  • packages/cipherstash-proxy/src/postgresql/backend.rs
  • packages/cipherstash-proxy/src/postgresql/context/mod.rs
  • packages/cipherstash-proxy/src/postgresql/frontend.rs
  • packages/cipherstash-proxy/src/postgresql/messages/bind.rs
  • packages/cipherstash-proxy/src/postgresql/messages/data_row.rs
  • packages/cipherstash-proxy/src/proxy/encrypt_config/manager.rs
  • packages/cipherstash-proxy/src/proxy/mod.rs
  • packages/cipherstash-proxy/src/proxy/zerokms/zerokms.rs
  • vendor/stack-auth/.gitignore
  • vendor/stack-auth/Cargo.toml
  • vendor/stack-auth/LICENSE
  • vendor/stack-auth/README.md
  • vendor/stack-auth/examples/auto_strategy.rs
  • vendor/stack-auth/examples/device_code.rs
  • vendor/stack-auth/src/access_key.rs
  • vendor/stack-auth/src/access_key_refresher.rs
  • vendor/stack-auth/src/access_key_strategy.rs
  • vendor/stack-auth/src/auto_refresh.rs
  • vendor/stack-auth/src/auto_strategy.rs
  • vendor/stack-auth/src/device_client.rs
  • vendor/stack-auth/src/device_code/mod.rs
  • vendor/stack-auth/src/device_code/protocol.rs
  • vendor/stack-auth/src/device_code/tests.rs
  • vendor/stack-auth/src/lib.rs
  • vendor/stack-auth/src/oauth_refresher.rs
  • vendor/stack-auth/src/oauth_strategy.rs
  • vendor/stack-auth/src/refresher.rs
  • vendor/stack-auth/src/service_token.rs
  • vendor/stack-auth/src/static_token_strategy.rs
  • vendor/stack-auth/src/token.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch james/cip-3233-proxy-drop-vendor-patch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…tack-auth patch (CIP-3233)

Moves Proxy off the `vendor/stack-auth` `[patch.crates-io]` workaround and onto the
current released cipherstash-client group, built against the fixed stack-auth.

Background: 2.2.4 (PR #408) shipped the CIP-3233 access-key token-refresh fix via
a vendored stack-auth patched on top of the 0.34.1-alpha.4 source. cipherstash-client
0.38.0 links stack-auth 0.38.0, which carries the same fix from crates.io, so the
vendored copy and patch are no longer needed.

Changes:
- cipherstash-client / cipherstash-config / cts-common: 0.34.1-alpha.4 -> 0.38.0
  (carries the API migration from PR #406's 0.37.0 upgrade; 0.37 -> 0.38 needed no
  further source changes)
- Remove `[patch.crates-io] stack-auth = { path = "vendor/stack-auth" }`, the
  `exclude = ["vendor/stack-auth"]` workspace entry, and the vendor/stack-auth tree
- stack-auth now resolves from crates.io (0.38.0); single version of the
  cipherstash-client group in the lock (zerokms-protocol 0.12.19)

Verified: `cargo check --workspace`, `cargo clippy --workspace --all-targets`, and
`cargo test --workspace --lib` (111 proxy unit tests) all pass. Integration tests
need a live DB/ZeroKMS and were not run here.
@freshtonic freshtonic force-pushed the james/cip-3233-proxy-drop-vendor-patch branch from 256ad08 to 2e11f69 Compare June 24, 2026 06:48
@freshtonic freshtonic changed the title chore(deps): upgrade cipherstash-client to 0.37.1, drop vendored stack-auth patch (CIP-3233) chore(deps): upgrade cipherstash-client to 0.38.0, drop vendored stack-auth patch (CIP-3233) Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants