Skip to content

CFE-4665: cfengine dev format docs should tell you what files it formatted#144

Open
sarakthon wants to merge 1 commit into
cfengine:mainfrom
sarakthon:print-formatted-files
Open

CFE-4665: cfengine dev format docs should tell you what files it formatted#144
sarakthon wants to merge 1 commit into
cfengine:mainfrom
sarakthon:print-formatted-files

Conversation

@sarakthon
Copy link
Copy Markdown
Contributor

Ticket: CFE-4665

@cf-bottom
Copy link
Copy Markdown

Thank you for submitting a PR! Maybe @larsewi can review this?

Copy link
Copy Markdown
Contributor

@larsewi larsewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Comment thread src/cfengine_cli/docs.py
return

if syntax_check:
# We currently only print the filenames during linting, not formatting
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olehermanse was there a specific reason for this?

Comment thread src/cfengine_cli/docs.py
Comment on lines 229 to 231
def _process_markdown_code_blocks(
path, languages, extract, syntax_check, output_check, autoformat, replace, cleanup
):
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, but I wish there was some doc string explaining these arguments. What is autoformat?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants