BINFR-6408: Add pull/push view-bookmarks commands#372
Open
Manjinder Singh (manjindersingh98) wants to merge 7 commits into
Open
BINFR-6408: Add pull/push view-bookmarks commands#372Manjinder Singh (manjindersingh98) wants to merge 7 commits into
Manjinder Singh (manjindersingh98) wants to merge 7 commits into
Conversation
Add `pull view-bookmarks` and `push view-bookmarks` commands to transfer view (board) bookmarks between teams, mirroring the existing analysis bookmarks implementation but targeting the blueprint BookmarksTransferController import/export endpoints (/blueprint/api/bookmarks). Includes-AI-Code: true Co-authored-by: Cursor <cursoragent@cursor.com>
Manjinder Singh (manjindersingh98)
requested a review
from a team
as a code owner
Copilot started reviewing on behalf of
Manjinder Singh (manjindersingh98)
June 10, 2026 07:56
View session
There was a problem hiding this comment.
Pull request overview
Adds new CLI support for transferring view (board) bookmarks via blueprint bookmark import/export endpoints, mirroring the existing analysis bookmarks flow.
Changes:
- Introduces
pull view-bookmarksandpush view-bookmarkscommands under a newsrc/commands/view/module. - Implements
ViewBookmarksManager+ factory/service to call/blueprint/api/bookmarks/export|importand write/readstudio_view_bookmarks_<boardId>.json. - Updates the user guide with usage examples for the new commands.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/commands/view/view-bookmarks.manager.ts | Adds blueprint bookmarks export/import manager (pull/push URLs, file naming, multipart body). |
| src/commands/view/view-bookmarks.manager-factory.ts | Creates/configures the manager, including defaults and file existence validation. |
| src/commands/view/view-bookmarks-command.service.ts | Exposes pull/push methods used by the CLI command handlers. |
| src/commands/view/module.ts | Registers pull view-bookmarks and push view-bookmarks commands and options. |
| docs/user-guide/studio-commands.md | Documents the new view bookmarks commands with example invocations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Can you also please handle the suggestions from Sonar? I think they make sense |
Manjinder Singh (manjindersingh98)
changed the title
Cover the new pull/push view-bookmarks module, command service, manager, and manager-factory (100% line/branch coverage) to satisfy SonarCloud coverage on new code. Includes-AI-Code: true Co-authored-by: Cursor <cursoragent@cursor.com>
|
Manjinder Singh (manjindersingh98)
requested review from
Copilot,
Jing Sun (kuvia) and
Thomas Neumüller (tneum-celonis)
Copilot started reviewing on behalf of
Manjinder Singh (manjindersingh98)
June 10, 2026 14:52
View session
|
general question: Manjinder Singh (@manjindersingh98) is this endpoint already configured to be accessible via the gateway? otherwise this command won't work |
|
|
||
| viewBookmarksManager.type = type; | ||
| if (filename !== null) { | ||
| viewBookmarksManager.fileName = this.resolveFilePath(filename); |
Contributor
There was a problem hiding this comment.
fileName
If we assign a path to this property then it should be called filePath imo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://celonis.atlassian.net/browse/BINFR-6408
Summary
pull view-bookmarksandpush view-bookmarkscommands to transfer view (board) bookmarks between teams.BookmarksTransferControllerimport/export endpoints (/blueprint/api/bookmarks/export|import).src/commands/view/(auto-discovered byModuleHandler): manager, manager-factory, command-service, and module registration.docs/user-guide/studio-commands.md.Details
pull view-bookmarks --id <boardId> [--type USER|SHARED|ALL]->GET /blueprint/api/bookmarks/export?boardId=<id>&type=<type>(defaults toUSER), writesstudio_view_bookmarks_<id>.json.push view-bookmarks --id <boardId> -f <file>->POST /blueprint/api/bookmarks/import?boardId=<id>(multipartfile).Test plan
npm run buildcompiles cleanlypull view-bookmarks --help/push view-bookmarks --helpshow expected optionsIncludes-AI-Code: true
Made with Cursor
Note
Low Risk
Follows the established analysis-bookmarks pattern with new blueprint endpoints; scope is CLI asset transfer and covered by unit tests, with no auth or core platform changes in this diff.
Overview
Adds content-cli support to pull and push view (board) bookmarks between teams, parallel to the existing analysis bookmarks flow but wired to blueprint
/blueprint/api/bookmarks/exportandimport.New
pull view-bookmarkstakes a board--idand optional--type(USERdefault,SHARED, orALL), downloads JSON asstudio_view_bookmarks_<boardId>.json.push view-bookmarksposts that file as multipart to the target board. Implementation lives undersrc/commands/view/(module registration, command service, manager + factory onBaseManager), with user-guide docs and Jest coverage; test setup aliasesnode:fsto the existingfsmock.Reviewed by Cursor Bugbot for commit 9c26621. Bugbot is set up for automated code reviews on this repo. Configure here.