Promote param property#1018
Open
henrydingliu wants to merge 3 commits into
Open
Conversation
promoting _param_property
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1018 +/- ##
=======================================
Coverage 89.17% 89.17%
=======================================
Files 89 89
Lines 5165 5166 +1
Branches 661 661
=======================================
+ Hits 4606 4607 +1
Misses 392 392
Partials 167 167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
_param_property is an private method that puts estimated parameters, like ldf, into a triangle. i need this function for DisposalRate, but don't want to duplicate code. so moving from incremenetaladditive to developmentbase
Related GitHub Issue(s)
refer #931
Additional Context for Reviewers
there is a nearly identical method inside development. but not touching till after friedland.
uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)Note
Cursor Bugbot is generating a summary for commit 0fccb70. Configure here.