promoting _param_property#1017
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## promote_param_property #1017 +/- ##
==========================================================
+ Coverage 88.94% 89.17% +0.23%
==========================================================
Files 89 89
Lines 5139 5166 +27
Branches 660 661 +1
==========================================================
+ Hits 4571 4607 +36
+ Misses 398 394 -4
+ Partials 170 165 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Related GitHub Issue(s)
Additional Context for Reviewers
uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)Note
Low Risk
Small refactor with no API change;
Developmentstill uses its own three-argument_param_propertyfor LDF/sigma/std_err.Overview
Moves
_param_propertyfromIncrementalAdditiveontoDevelopmentBaseas a shared static helper that wraps fitted parameter arrays into a patternTriangle(ultimate valuation, additive/non-cumulative flags, slicers).IncrementalAdditive.fitnow calls the inherited helper instead of a local duplicate._set_fit_groupstype hints switch fromTriangleLiketo concreteTriangleunderTYPE_CHECKING.Reviewed by Cursor Bugbot for commit d189394. Bugbot is set up for automated code reviews on this repo. Configure here.