[Feat] Add rolloutOnCredentialUpdate field to chart#114
Merged
Conversation
- Updated the app struct in schema-generation.go to include a new boolean field `RolloutOnCredentialUpdate`. - Modified the Helm templates to conditionally include the `rolloutOnCredentialUpdate` field in the generated YAML files based on the new configuration. - Ensured that the new field is reflected in all relevant expected output files for consistency.
![hyperspace-insights[bot]](https://avatars.githubusercontent.com/u/2531208?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
The PR adds a rolloutOnCredentialUpdate boolean field across Helm chart schemas, Go struct, template generation, and test fixtures. The core logic issue is that the Helm conditional {{- if .Values.app.rolloutOnCredentialUpdate }} will never render rolloutOnCredentialUpdate: false (an explicit opt-out) since false is falsy in Go templates — this affects lib/util.js and all generated test fixture YAML files consistently. Additionally, a go.sum entry for klauspost/compress v1.18.6 appears without a corresponding go.mod bump, which should be cleaned up with go mod tidy.
PR Bot Information
Version: 1.26.13
- LLM:
anthropic--claude-4.6-sonnet - File Content Strategy: Full file content
- Event Trigger:
pull_request.opened - Correlation ID: ``
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
rolloutOnCredentialUpdateField to ChartNew Features
✨ Introduces a new optional boolean field
rolloutOnCredentialUpdateto theappconfiguration in the Helm chart. When enabled, this field is conditionally rendered in theCAPApplicationresource spec, allowing users to control rollout behavior on credential updates.Changes
hack/schema-generation.go: AddedRolloutOnCredentialUpdate boolfield to theappstruct to support schema generation for the new configuration option.files/chart/values.schema.json&files/configurableTemplatesChart/values.schema.json: AddedrolloutOnCredentialUpdateas an optional boolean property in theappschema definition.lib/util.js: Updated the Helm template generation logic to conditionally includerolloutOnCredentialUpdatein the generated YAML when the value is set.test/files/expectedChart/templates/cap-operator-cros*.yaml&test/files/expectedConfigurableTemplatesChart/templates/cap-operator-cros*.yaml: Updated all expected output YAML templates to include the conditionalrolloutOnCredentialUpdateblock.hack/go.mod&hack/go.sum: Bumped several dependency versions includinggo(1.26.3 → 1.26.4),sap-btp-service-operator(v0.11.1 → v0.11.6),cap-operator(v0.30.0 → v0.32.0), and variousgo-openapi/swag,prometheus, andk8s.iopackages.PR Bot Information
Version:
1.26.13issue_comment.edited