Skip to content

deps: explicit the @oclif/core dependency used in main.js#609

Merged
paulRbr merged 2 commits into
bump-sh:mainfrom
paulRbr:explicit-oclif-core-dependency
Jun 16, 2026
Merged

deps: explicit the @oclif/core dependency used in main.js#609
paulRbr merged 2 commits into
bump-sh:mainfrom
paulRbr:explicit-oclif-core-dependency

Conversation

@paulRbr

@paulRbr paulRbr commented Jun 15, 2026

Copy link
Copy Markdown
Member

This commit explicits the dependency on @oclif/core (we use the Config
type from that lib in the main.js file) instead on relying on implicit
dependency (from the bump-cli package).

@paulRbr paulRbr self-assigned this Jun 15, 2026
@paulRbr paulRbr requested a review from Polo2 June 15, 2026 14:34
@Polo2

Polo2 commented Jun 15, 2026

Copy link
Copy Markdown
Member

About conflicts, looks like the last version of the bump-cli 2.10.0 has to be used 😇
6aff793

@paulRbr

paulRbr commented Jun 15, 2026

Copy link
Copy Markdown
Member Author

About conflicts

Which conflits are we talking about?

@paulRbr paulRbr enabled auto-merge (rebase) June 16, 2026 07:51
paulRbr added 2 commits June 16, 2026 09:57
This commit explicits the dependency on @oclif/core (we use the Config
type from that lib in the main.js file) instead on relying on implicit
dependency (from the bump-cli package).
@paulRbr paulRbr force-pushed the explicit-oclif-core-dependency branch from 2965c10 to 6c3a909 Compare June 16, 2026 13:54
@paulRbr

paulRbr commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

Thanks @Polo2 I didn't even see I was not up-to-date with main 🤦

@paulRbr

paulRbr commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

ℹ️ note for reviewer: I've enabled auto-merge as I'm confident about sending this change to production

@Polo2 Polo2 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Comment thread package.json
"@actions/io": "^1.1.3",
"@octokit/types": "^14.1.0",
"bump-cli": "^2.10.0"
"bump-cli": "^2.10.0",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and soon 2.10.1 (I'll do it in #607 )

@paulRbr paulRbr merged commit 560f060 into bump-sh:main Jun 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants