[TEST] test https://github.com/composefs/composefs-rs/pull/321#2266
Draft
giuseppe wants to merge 1 commit into
Draft
[TEST] test https://github.com/composefs/composefs-rs/pull/321#2266giuseppe wants to merge 1 commit into
giuseppe wants to merge 1 commit into
Conversation
Author
|
@cgwalters is this test what you had in mind? |
cgwalters
reviewed
Jun 24, 2026
cgwalters
left a comment
cgwalters
left a comment
Collaborator
There was a problem hiding this comment.
Yes, doing it this way runs more tests, but there is also support for revdep testing in composefs-rs that we could wire things up to directly as well
| cd /composefs-rs/src | ||
| cargo build --release -p composefs-capi | ||
| mkdir -p /out | ||
| cp target/release/libcomposefs_capi.so /out/ |
Collaborator
There was a problem hiding this comment.
Would be better to have e.g. make install DESTDIR= support. Maybe it should be make install-capi.
cgwalters
added
the
ci/merge
Collaborator
|
For PRs like this, add the |
giuseppe
force-pushed
the
test-composefs-rs-cdynlib
branch
from
9f9b495 to
6b85e72
Compare
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
test-composefs-rs-cdynlib
branch
from
6b85e72 to
fc7e828
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.