Detect external bootc status changes via fsnotify (milestone 4d)#59
Open
alicefr wants to merge 2 commits into
Open
Detect external bootc status changes via fsnotify (milestone 4d)#59alicefr wants to merge 2 commits into
alicefr wants to merge 2 commits into
Conversation
alicefr
force-pushed
the
milestone-4d
branch
4 times, most recently
from
8021bcf to
74c721d
Compare
alicefr
force-pushed
the
milestone-4d
branch
3 times, most recently
from
79041e3 to
069de0b
Compare
Add a StatusWatcher component that detects external bootc status changes via fsnotify on /proc/1/root/ostree/bootc (with fallback to /proc/1/root/sysroot/state/deploy for composefs), plus a configurable polling interval as a safety net. Assisted-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Alice Frosi <afrosi@redhat.com>
Add --poll-interval flag to the daemon binary and wire the StatusWatcher channel into the reconciler as a second WatchesRawSource alongside switchDone. Assisted-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Alice Frosi <afrosi@redhat.com>
jlebon
reviewed
Jun 24, 2026
| Complete(r) | ||
| Named("bootcnode") | ||
|
|
||
| if r.StatusChanged != nil { |
|
|
||
| func main() { | ||
| var pollInterval time.Duration | ||
| flag.DurationVar(&pollInterval, "poll-interval", 5*time.Minute, "Interval for polling bootc status as a fallback to fsnotify") |
Collaborator
There was a problem hiding this comment.
Perhaps bootc-pool-interval?
| DefaultFallbackPath = "/proc/1/root/sysroot/state/deploy" | ||
| ) | ||
|
|
||
| type StatusWatcher struct { |
Collaborator
There was a problem hiding this comment.
So the way I was thinking about this was more like if it were an "informer cache" for bootc status.
So here we would maintain the deserialized status, and the daemon whenever it needed it, would query the status watcher and that either returns the in-memory object (if fsnotify is known healthy), or run bootc status --json.
The polling fallback still makes sense I guess to keep the BootcNode status up to date even if the daemon itself doesn't need to do any work. But ideally we only start polling once fsnotify fails?
WDYT?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bootc changes are detected via fsnotify or via a polling mechanism.
This is built on top of #50