Fix tooth numbering#22
Open
AmirabbasJ wants to merge 1 commit into
Open
Conversation
|
@AmirabbasJ is attempting to deploy a commit to the Pratik Sharma's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there, great package you made, keep it up, man.
I just noticed one major issue: the way you're mapping the FDI tooth numbering is flawed. This is from your storybook example:
You see, this should be
48and not38. This issue goes for the whole lower jaw, and also, if you only show the lower jaw, the numbers are wrong again:I fixed this issue in this PR. It looks like your code labels some pairs of teeth as "upper left" when they're actually styled to be "upper right".
I also fixed the issue that I mentioned above by examples, by hard-coding the prefix inside each quadrant, because the main reason that the mapping was going wrong was because you were relying on
indexwhich is not a good idea.