fix(web): make widget/embed mode hermetic; pin the docs demo defaults#33
Merged
Conversation
Several <chart-plotter widget> embeds share one origin on the docs site (the intro demo + the Chart 1 reference page), so persisting display state in localStorage let one clobber another — e.g. the reference page's dataQuality:true and its lat-15 view leaking onto the intro demo. Make widget (embed) mode HERMETIC for display settings: it neither reads nor writes the shared keys chartplotter:mariner/:scheme/:basemap/:view. Embeds boot from DEFAULT_MARINER and the scheme/basemap/center/zoom attributes, and set their own state via applyMariner/applyScheme at ready. Read-gating (not just write) is what fixes already-polluted browsers. Widget mode also skips the auto-frame paths so the pinned center/zoom always wins. The real app is server mode (not widget) and persists via /api/settings, so it is unaffected. Pin the intro demo (LiveChart) defaults now that the embed must force its own state: Annapolis (38°58.5′N 076°28.9′W) at 1:6090, Display category Other on, and chart scale boundaries on. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several embeds share one origin on the docs site (the intro demo + the Chart 1 reference page), so persisting display state in localStorage let one clobber another — e.g. the reference page's dataQuality:true and its lat-15 view leaking onto the intro demo.
Make widget (embed) mode HERMETIC for display settings: it neither reads nor writes the shared keys chartplotter:mariner/:scheme/:basemap/:view. Embeds boot from DEFAULT_MARINER and the scheme/basemap/center/zoom attributes, and set their own state via applyMariner/applyScheme at ready. Read-gating (not just write) is what fixes already-polluted browsers. Widget mode also skips the auto-frame paths so the pinned center/zoom always wins. The real app is server mode (not widget) and persists via /api/settings, so it is unaffected.
Pin the intro demo (LiveChart) defaults now that the embed must force its own state: Annapolis (38°58.5′N 076°28.9′W) at 1:6090, Display category Other on, and chart scale boundaries on.