Proposals for traits for symmetric ciphers#13
Open
ounsworth wants to merge 3 commits into
Open
Conversation
officialfrancismendoza
requested changes
Jun 3, 2026
officialfrancismendoza
left a comment
officialfrancismendoza
left a comment
There was a problem hiding this comment.
Wanted to check possible bugs in tests and the AEAD tampering test potentially allowing successful corrupted decrypts.
|
@ounsworth merge conflict in QUALITY_AND_STYLE.md. Also had a few unresolved comments about presumably mismatched key usage (ie: mac_key instead of key and vice versa), permuting over a different key, etc. |
romen
reviewed
Jun 5, 2026
| } | ||
|
|
||
| pub trait Hash : Default { | ||
| /// The basic one-shat encrypt and decrypt that all types of symmetric ciphers must implement. |
Contributor
Author
Well-spotted. I'm I have you as a second pair of eyes! As I said, I wrote these traits and tests without any actual code, so I entrust this to you: feel free to adjust any of it as you develop ascon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.