Skip to content

fix replication requests exceeding maxRoundWindow + splitting resends#431

Open
jadalsmail wants to merge 3 commits into
mainfrom
fix-replication-request-splitting
Open

fix replication requests exceeding maxRoundWindow + splitting resends#431
jadalsmail wants to merge 3 commits into
mainfrom
fix-replication-request-splitting

Conversation

@jadalsmail

Copy link
Copy Markdown
Collaborator

This PR fixes the following bugs:

  1. When a node sends a replication requests, it sends more than maxRoundWindow (off-by-one)
  2. in resendReplicationRequests, we aggregate continuous sequences which can be larger than maxRoundWindow

Also, two unit tests testing this functionality were added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant