action: fail closed on a malformed identity bundle#19
Merged
Conversation
The TTL check read max_valid_for_secs directly, so a bundle missing that field (or bundle_timestamp) made the staleness comparison `age > undefined` evaluate to false, silently skipping the check and accepting a malformed bundle. Bundle shape is now validated before it is trusted: a missing or invalid timestamp or TTL, or unparseable JSON, is rejected. Adds tests for each malformed shape.
Auths Commit Verification
Result: ❌ 0/1 commits verified How to fixCommit 1. Install auths macOS: 2. One-time setup (creates your identity and configures Git) auths init3. Sign this branch and push auths sign origin/main..HEAD
git push --force-with-leaseFor CI to verify the signer, commit an identity bundle: auths id export-bundle --alias main --output .auths/ci-bundle.json --max-age-secs 2592000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TTL check read max_valid_for_secs directly, so a bundle missing that field
(or bundle_timestamp) made the staleness comparison
age > undefinedevaluateto false, silently skipping the check and accepting a malformed bundle. Bundle
shape is now validated before it is trusted: a missing or invalid timestamp or
TTL, or unparseable JSON, is rejected. Adds tests for each malformed shape.