verifier-install: re-verify the binary on cache hits#16
Closed
bordumb wants to merge 1 commit into
Closed
Conversation
A cached or cross-run-restored auths binary was returned without checking it, so a poisoned cache entry would run unverified — and for a verification action a tampered binary can report success for everything. Both cache paths now re-verify the binary against the release checksum before use, and a checksum failure on a restored binary is surfaced rather than swallowed as a routine cache miss. Adds adversarial tests for tampered tool-cache and cross-run-cache entries.
Auths Commit Verification
Result: ❌ 0/1 commits verified How to fixCommit 1. Install auths macOS: 2. One-time setup (creates your identity and configures Git) auths init3. Sign this branch and push auths sign origin/main..HEAD
git push --force-with-leaseFor CI to verify the signer, commit an identity bundle: auths id export-bundle --alias main --output .auths/ci-bundle.json --max-age-secs 31536000 |
Contributor
Author
|
Merged into main directly as d163de3 (rebased onto origin/main to reconcile with a concurrent docs commit). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A cached or cross-run-restored auths binary was returned without checking it,
so a poisoned cache entry would run unverified — and for a verification action
a tampered binary can report success for everything. Both cache paths now
re-verify the binary against the release checksum before use, and a checksum
failure on a restored binary is surfaced rather than swallowed as a routine
cache miss. Adds adversarial tests for tampered tool-cache and cross-run-cache
entries.