Skip to content

Add token refresh logic if the user's access token is expired #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShanChathusanda93 merged 1 commit into from
Jun 8, 2026
Merged

Add token refresh logic if the user's access token is expired #528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/hot-wombats-lick.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@asgardeo/browser': patch
---

Add token refresh logic if the user's access token is expired
2 changes: 1 addition & 1 deletion .github/workflows/pr-builder.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
strategy:
matrix:
node-version: [lts/*]
pnpm-version: [v10]
pnpm-version: [latest]
steps:
- name: ⬇️ Checkout
id: checkout
Expand Down
24 changes: 23 additions & 1 deletion packages/browser/src/__legacy__/helpers/authentication-helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,6 +706,28 @@ export class AuthenticationHelper<T extends MainThreadClientConfig | WebWorkerCl
}

public async isSignedIn(): Promise<boolean> {
return this._authenticationClient.isSignedIn();
if (await this._authenticationClient.isSignedIn()) {
return true;
}

// A refresh is already in progress — wait for it to finish then re-check.
if (this._isTokenRefreshing) {
await SPAUtils.until(() => !this._isTokenRefreshing);

return this._authenticationClient.isSignedIn();
}

// Token may be expired — attempt a silent refresh before giving up.
try {
this._isTokenRefreshing = true;
await this.refreshAccessToken();
this._isTokenRefreshing = false;

return true;
} catch {
this._isTokenRefreshing = false;

return false;
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Comment on lines +709 to +731

@pavinduLakshan pavinduLakshan Jun 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we could use something like the following version to keep this._authenticationClient.isSignedIn method as the single source for determining the signed in status, instead of explicitly returning boolean status. (haven't tested the following myself though)

public async isSignedIn(): Promise<boolean> {
    if (await this._authenticationClient.isSignedIn()) {
        return this._authenticationClient.isSignedIn();
    }

    if (this._isTokenRefreshing) {
        await SPAUtils.until(() => !this._isTokenRefreshing);

        return this._authenticationClient.isSignedIn();
    }

    try {
        this._isTokenRefreshing = true;
        await this.refreshAccessToken();
    } catch {
        // Ignore refresh failures. Signed-in state is determined below.
    } finally {
        this._isTokenRefreshing = false;
    }

    return this._authenticationClient.isSignedIn();
}

@brionmario brionmario Jun 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to do this IMO. But +1 to merge the already tested path immediately and later bring this in.

}
}
Loading