Fix locale-dependent JSON float parsing in fvec_from_value#303
Open
stumpylog wants to merge 1 commit into
Open
Fix locale-dependent JSON float parsing in fvec_from_value#303stumpylog wants to merge 1 commit into
stumpylog wants to merge 1 commit into
Conversation
…017#241) Replace strtod() with a custom strtod_c() that always uses '.' as the decimal separator. strtod(3) respects LC_NUMERIC, so locales like fr_FR or de_DE caused JSON vector literals (e.g. '[0.1, 0.2, 0.3]') to be rejected with "JSON parsing error".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace strtod() with a custom strtod_c() that always uses '.' as the decimal separator. strtod(3) respects LC_NUMERIC, so locales like fr_FR or de_DE caused JSON vector literals (e.g. '[0.1, 0.2, 0.3]') to be rejected with "JSON parsing error".
fixes #241