Fix external gate#107
Open
MarkRivers wants to merge 2 commits into
Open
Conversation
state=Idle at the end of acquisition. This problem might be confined to the GSECARS eiger2 9M which is a hybrid between an Eiger2S and an Eiger 2X. We need to re-introduce the logic to wait for NumImages=ExpectedImages. It now waits for whichever comes first: state=Idle, NumImages=ExpectedImages, or manual stop event.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have found that in ExternalGate mode the detector does not set state=Idle at the end of acquisition.
This problem might be confined to the GSECARS eiger2 9M which is a hybrid between an Eiger2S and an Eiger 2X.
We need to re-introduce the logic to wait for NumImages=ExpectedImages.
controlTask now waits for whichever comes first: