Skip to content

fix(mongodb): avoid sharded config render helper dependency#2747

Open
weicao wants to merge 1 commit into
fix/mongodb-cmpd-volumes-null-kb12from
brooks/mongodb-sharded-config-template-compat
Open

fix(mongodb): avoid sharded config render helper dependency#2747
weicao wants to merge 1 commit into
fix/mongodb-cmpd-volumes-null-kb12from
brooks/mongodb-sharded-config-template-compat

Conversation

@weicao
Copy link
Copy Markdown
Contributor

@weicao weicao commented Jun 3, 2026

Summary

Evidence

  • Local worktree based on fix(mongodb): avoid rendering null volumes in CmpD templates #2742 head d33c3033b36c28bed22ab8675d7900a40e796524
  • git diff --check PASS
  • helm template kb-addon-mongodb addons/mongodb -n kb-system PASS
  • Rendered output has no getVolumePathByName / getPortByName / getContainerMemory tokens and no volumes: null
  • Target runner focused validation on KB 1.2.0-alpha.1: sharded Cluster reached Running, mongos marker write/read rc=0

Boundary

  • Runtime validation used a patched addon chart in mason-idc-mongodb-vc; cleanup exposed a separate KB finalizer cleanup issue, so cleanup is not claimed as normal CLEAN PASS.
  • This PR only addresses the config-render helper dependency.

@weicao weicao requested review from a team, leon-ape and xuriwuyun as code owners June 3, 2026 11:06
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (fix/mongodb-cmpd-volumes-null-kb12@d33c303). Learn more about missing BASE report.

Additional details and impacted files
@@                         Coverage Diff                          @@
##             fix/mongodb-cmpd-volumes-null-kb12   #2747   +/-   ##
====================================================================
  Coverage                                      ?   0.00%           
====================================================================
  Files                                         ?      73           
  Lines                                         ?    9236           
  Branches                                      ?       0           
====================================================================
  Hits                                          ?       0           
  Misses                                        ?    9236           
  Partials                                      ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants