Remove unused PROJECT_SRC_DIR from cpp CMakeLists#842
Open
SpriCoder wants to merge 1 commit into
Open
Conversation
The variable was introduced in apache#364 but has never been referenced anywhere in the build. Per maintainer guidance, consumers (CLI, tests, examples, external users) must resolve library headers from the staged include tree (LIBRARY_INCLUDE_DIR) and link the shared library, never reach into the source tree, so a variable pointing at cpp/src should not exist as a temptation. Verified: full Debug build (library + tsfile-cli + TsFile_Test) and the complete GTest suite (641 tests) pass; tsfile-cli write/count/cat round-trip works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PROJECT_SRC_DIRvariable fromcpp/CMakeLists.txt. It was introduced in Separate header file dependencies for test and src. #364 and has never been referenced anywhere in the build (verified across the full git history).LIBRARY_INCLUDE_DIR) and link the shared library, never reach intocpp/src— so a variable pointing at the source tree should not exist as a temptation for future targets.Test plan
-DBUILD_TEST=ON -DENABLE_ANTLR4=OFF): library,tsfile-cli, andTsFile_Testall compile and link.tsfile-clismoke:--version/--help, plus awrite(stdin CSV) →count→catround-trip.grep PROJECT_SRC_DIRover the repo and the generatedCMakeCache.txt: zero remaining references.