Fix C++ TsFile writer flush offsets for multi-GB files.#839
Merged
Conversation
Sync file_base_offset after flush, reset the write stream and consumer, and add tree/table 4GB regression tests.
Mirror C++ tree/table ~4GB regression coverage in pytest and drop POSIX-only headers from large-file gtests.
Keep shared constants and utilities in one pytest entry point for tree/table 4GB tests.
jt2594838
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flush_stream_to_file()so chunk/metadata offsets stay correct after repeated flushes on multi-GB files.ByteStreamconsumer state after flush; useint64_tfor aligned chunk read offsets.Test plan