HDDS-15550 Added an option to bypass bufferpool usage for large writes#10501
Open
yandrey321 wants to merge 1 commit into
Open
HDDS-15550 Added an option to bypass bufferpool usage for large writes#10501yandrey321 wants to merge 1 commit into
yandrey321 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added an option to bypass bufferpool usage for large writes: if write is 1+MB in size the buffer pool usage might overweight the benefit of larger writes, instead the client can send the client's buffer to netty directly and wait for async send completion. With a constant cost of the send/processing writes on the backend, the approach without pool shows better throughput and better scaling with increasing number of threads.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15550
How was this patch tested?
Run synthetic benchmark that trying to mimic 'ozone dreon dfsg' workflow.
Results for running on ARM based mac with 14 CPUs:
--- scaling summary writeSize=4096KB ---
--- scaling summary writeSize=3072KB ---
--- scaling summary writeSize=2048KB ---
--- scaling summary writeSize=1024KB ---