Skip to content

HDDS-15182. [STS] Remove latent extra read on CopyObject api - make CopyPart work similarly#10203

Open
fmorg-git wants to merge 1 commit into
apache:HDDS-13323-stsfrom
fmorg-git:HDDS-15182
Open

HDDS-15182. [STS] Remove latent extra read on CopyObject api - make CopyPart work similarly#10203
fmorg-git wants to merge 1 commit into
apache:HDDS-13323-stsfrom
fmorg-git:HDDS-15182

Conversation

@fmorg-git

@fmorg-git fmorg-git commented May 6, 2026

Copy link
Copy Markdown
Contributor

Please describe your PR in detail:

  • In STS, CopyObject requires s3:GetObject action on source and s3:PutObject action on destination in order to successfully invoke the api. In the latent S3 implementation, the code was doing an additional read on the destination object to get the eTag and modificationTime when the file was created. This is problematic, because AWS doesn't require s3:GetObject action on the destination file, so this extra read was causing STS smoke tests to fail.

In order to address, don't do the extra read (which will help performance as well) and instead make the commit key call return the modification time in the response and use that. Furthermore, the code already knows what the md5Hash/eTag is, so there is no need to read the destination object.

For consistency, make uploadPartCopy similarly return the modification time as well.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-15182

How was this patch tested?

unit tests, smoke tests

@fmorg-git fmorg-git changed the base branch from master to HDDS-13323-sts May 6, 2026 19:07
@fmorg-git fmorg-git marked this pull request as draft May 6, 2026 19:36
@fmorg-git fmorg-git force-pushed the HDDS-15182 branch 3 times, most recently from fdbfdd7 to a6364b3 Compare May 16, 2026 02:21
@github-actions

github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown

This PR has been marked as stale due to 21 days of inactivity. Please comment or remove the stale label to keep it open. Otherwise, it will be automatically closed in 7 days.

@github-actions github-actions Bot added the stale label Jun 7, 2026
@fmorg-git

Copy link
Copy Markdown
Contributor Author

commenting to remove stale label

@github-actions github-actions Bot removed the stale label Jun 8, 2026
…arly

 Conflicts:
	hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto
@fmorg-git fmorg-git marked this pull request as ready for review June 12, 2026 10:17
@fmorg-git

Copy link
Copy Markdown
Contributor Author

hi @ChenSammi - this PR has been rebased and ready to review once the workflow checks pass. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant