feat(io): add VendedCredentialsProvider for S3 credential refresh#3507
Open
gabeiglio wants to merge 2 commits into
Open
feat(io): add VendedCredentialsProvider for S3 credential refresh#3507gabeiglio wants to merge 2 commits into
gabeiglio wants to merge 2 commits into
Conversation
gabeiglio
force-pushed
the
vended-credentials-provider
branch
from
139d3a1 to
ea0777c
Compare
| Args: | ||
| provider (VendedCredentialsProvider): A concrete type of VendedCredentialsProvider (e.g S3VendedCredentialsProvider) | ||
| """ | ||
|
|
Collaborator
There was a problem hiding this comment.
Can we put a TODO and a pass in here? That should be enough to get rid of the noqa: B027. I believe that will be enough to get rid of that type exception.
I actually have no issues with assigning the provider to an internal variable (that isn't yet used)
| credentials: list[StorageCredential] = Field(alias="storage-credentials") | ||
|
|
||
|
|
||
| class VendedCredentialsProvider: |
Collaborator
There was a problem hiding this comment.
This class seems to be handling two different situations:
- A generic provider for handling vended credentials
- An implementation that handles for S3.
Can we split up the first part into a ABC and then the second part as an implementation?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces the credential provider class and the set_credentials_provider hook on the FileIO base class. No FileIO implementation is wired yet.
Rationale for this change
First PR to implement automatic vended credential refresh in PyIceberg.
See epic issue here
Are these changes tested?
Yes, created
test_credentials_provider.pyAre there any user-facing changes?
Yes, users will have support for new config properties like