docs: adopt issue #4419 terminology in Scala/Java UDF guide#4651
Open
andygrove wants to merge 1 commit into
Open
docs: adopt issue #4419 terminology in Scala/Java UDF guide#4651andygrove wants to merge 1 commit into
andygrove wants to merge 1 commit into
Conversation
Replace bare uses of "native" with terms from the apache#4419 framework: "Comet pipeline" for pipeline membership, "Rust-implemented" for the surrounding operators, and "run in the Comet pipeline" / "keep execution in the Comet pipeline" in place of "native path" / "native execution".
comphead
reviewed
Jun 13, 2026
| | `spark.comet.exec.scalaUDF.codegen.enabled` | `true` | When `true`, eligible `ScalaUDF`s run on the Comet path. When `false`, the enclosing operator falls back to Spark. | | ||
| | Key | Default | Description | | ||
| | ------------------------------------------- | ------- | ---------------------------------------------------------------------------------------------------------------------- | | ||
| | `spark.comet.exec.scalaUDF.codegen.enabled` | `true` | When `true`, eligible `ScalaUDF`s run in the Comet pipeline. When `false`, the enclosing operator falls back to Spark. | |
Contributor
There was a problem hiding this comment.
perhaps we need to highlight this param contols a fallback for user defined functions codegen, having another config for builtin Spark functions codegen?
comphead
approved these changes
Jun 13, 2026
comphead
left a comment
Contributor
There was a problem hiding this comment.
Thanks @andygrove overall it is a good improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #4419.
Rationale for this change
Issue #4419 proposes a terminology framework to remove the overloaded, bare use of "native" from Comet's docs. The "Scala UDF and Java UDF Support" page describes how UDFs participate in Comet execution and used "native Comet path" / "native path" / "native execution" loosely. This page is a good follow-up to the Understanding Comet Plans cleanup because Scala/Java UDFs are JVM-implemented (codegen'd) yet still run inside the Comet pipeline, so precise wording matters here.
This PR keeps the change scoped to that one page.
What changes are included in this PR?
In
docs/source/user-guide/latest/scala_java_udfs.md:How are these changes tested?
Documentation-only change. Verified with
prettier --check.