chore: refactor CI to have centralized SBT action#4643
Merged
Conversation
spark.comet.memoryOverhead in tests
andygrove
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
CI: split Spark SBT compile from test execution
Problem
sql_core-*matrix entries randomly SIGKILL on Spark 4.1.2 runners withKilled(no JVM stack) — the kernel/container OOM killer, not-Xmxexhaustion. Each matrix entry runssbt -mem 3072 testOnly *, so SBT pays the full Scala/Zinc compile heap (~2.5–3 GB peak) and then orchestrates the forked test JVM, on top of Comet's native off-heap pool, on a 7 GB hosted runner. The budget is at theedge; cumulative allocation patterns push it over non-deterministically.
Change
buildjob per Spark version: buildslibcomet.so(cargo--profile ci) and runssbt -mem 3072 catalyst/Test/compile sql/Test/compile hive/Test/compileonce. Uploads twoartifacts:
native-lib-linux(libcomet.so, ~50 MB)jvm-compiled-spark-<full>-jdk<N>(apache-spark.tar.gz, sources +target/+ Zinc state, ~500 MB–1 GB, mtimes preserved viatar -czpf)spark-sql-testentriesneeds: build, download + extract both, callsetup-spark-builderwithskip-spark-clone: true(only re-runs themvn installof Comet's JAR), thensbt -mem 1536 testOnly *. Zinc verifies "no source changed" and skips compile.setup-spark-buildergains askip-spark-cloneinput to gate the Spark checkout + diff apply when sources are pre-staged from the artifact.Effect
build-native+ 7×(compile+test)= 8; nowbuild(native + compile) + 7×test= 8 — same job count, but the heavy compile is amortized.