Fix int overflow in PCX image buffer sizing, now throws AllocationRequestException#552
Merged
Merged
Conversation
garydgregory
requested changes
Jun 21, 2026
garydgregory
left a comment
Member
There was a problem hiding this comment.
@alhudz
There is no test for this PR.
Contributor
Author
|
Added one in
Verified the test fails on |
Member
|
@alhudz |
Contributor
Author
|
Good catch. Running |
garydgregory
added a commit
that referenced
this pull request
Jun 23, 2026
AllocationRequestException (#552).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading the PCX decoder I noticed
getBufferedImagesizes the pixel buffer with int multiplies ofxSize/ySize, which both come from uint16 header fields and can reach 65536. For 24/32-bit and 8-bit/3-plane imagesrowLength * ySize,xSize * ySizeandySize * bytesPerImageRowoverflow int and wrap small, so the value slips past theAllocator1 GB guard and an undersized buffer feeds an out-of-boundsarraycopy. Computing in long lets the existingAllocator.byteArray(long)overload reject the real size instead.