Fix ISO tagging tests: wait for ISO download before tagging operations#13368
Open
awen11123 wants to merge 1 commit into
Open
Fix ISO tagging tests: wait for ISO download before tagging operations#13368awen11123 wants to merge 1 commit into
awen11123 wants to merge 1 commit into
Conversation
The create_iso() helper in test_tags.py calls Iso.create() and immediately returns, but the ISO may still be downloading when tagging tests proceed. This causes tests 7, 16, and 17 to fail intermittently with upload errors. Call iso.download() after creation, which has a built-in retry loop that waits for the ISO to reach 'Successfully Installed' and isready state. If the download fails after the retry period, skip the test instead of failing with an opaque upload error. Fixes intermittent failures in test_07_iso_tag, test_16_query_tags_other_account, and test_17_query_tags_admin_account.
boring-cyborg
Bot
added
component:integration-test
Python
|
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖
Description
The
create_iso()helper intest/integration/component/test_tags.pycallsIso.create()and immediately returns, but the ISO may still be downloading when tagging tests proceed. This causes tests 7, 16, and 17 to fail intermittently when the ISO upload hasn't completed.This PR adds a call to
iso.download()after creation. Thedownload()method (on theIsoclass in marvin) already has a built-in retry loop (300 retries × 5s interval) that waits for the ISO to reachSuccessfully Installedandisreadystate.If the download fails after the retry period, the test is skipped with a clear message rather than failing with an opaque upload error.
Types of changes
Fixes
Fixes #7041
Affected tests
test_07_iso_tagtest_16_query_tags_other_accounttest_17_query_tags_admin_account