Skip to content

CLVM enhancements and fixes #12617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Pearl1594 wants to merge 84 commits into
base: main
Choose a base branch
from

address comment - extract common code for endpoint identification if …

90843cb
Select commit
Loading
Failed to load commit list.
Draft

CLVM enhancements and fixes #12617

address comment - extract common code for endpoint identification if …
90843cb
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Jun 8, 2026 in 4m 59s

Quality Gate failed

Failed conditions
1 Security Hotspot
34.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

Annotations

Check failure on line 285 in server/src/main/java/com/cloud/storage/clvm/ClvmPoolManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Null is returned but a "Boolean" is expected. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSjr-GQEym9Vaoma&open=AZ6opSjr-GQEym9Vaoma&pullRequest=12617

Check warning on line 368 in engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_volsDetailsDao" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSL3-GQEym9Vaojs&open=AZ6opSL3-GQEym9Vaojs&pullRequest=12617

Check warning on line 77 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStoragePoolManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this "Map.containsKey()" with a call to "Map.computeIfAbsent()". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSWz-GQEym9Vaokp&open=AZ6opSWz-GQEym9Vaokp&pullRequest=12617

Check warning on line 1022 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Script"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSWO-GQEym9Vaokn&open=AZ6opSWO-GQEym9Vaokn&pullRequest=12617

Check warning on line 1336 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace charset name argument with StandardCharsets.UTF_8 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSXu-GQEym9Vaok3&open=AZ6opSXu-GQEym9Vaok3&pullRequest=12617

Check warning on line 274 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPostMigrationCommandWrapperTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'org.libvirt.LibvirtException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSZ6-GQEym9VaolK&open=AZ6opSZ6-GQEym9VaolK&pullRequest=12617

Check warning on line 7549 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless assignment to local variable "clustered". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSa8-GQEym9VaolP&open=AZ6opSa8-GQEym9VaolP&pullRequest=12617

Check warning on line 283 in engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_agentMgr" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSGr-GQEym9Vaojl&open=AZ6opSGr-GQEym9Vaojl&pullRequest=12617

Check failure on line 786 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSek-GQEym9Vaoly&open=AZ6opSek-GQEym9Vaoly&pullRequest=12617

Check failure on line 343 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSea-GQEym9Vaolg&open=AZ6opSea-GQEym9Vaolg&pullRequest=12617

Check warning on line 2992 in server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused private "findVolumeLockHost" method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSlQ-GQEym9Vaome&open=AZ6opSlQ-GQEym9Vaome&pullRequest=12617

Check warning on line 2758 in server/src/test/java/com/cloud/storage/VolumeApiServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this and every subsequent useless "eq(...)" invocation; pass the values directly. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSuk-GQEym9Vaom6&open=AZ6opSuk-GQEym9Vaom6&pullRequest=12617

Check warning on line 7208 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "details" which hides the field declared at line 260. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSa8-GQEym9VaolO&open=AZ6opSa8-GQEym9VaolO&pullRequest=12617

Check failure on line 806 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSek-GQEym9Vaolz&open=AZ6opSek-GQEym9Vaolz&pullRequest=12617

Check warning on line 32 in core/src/main/java/org/apache/cloudstack/storage/clvm/command/ClvmLockTransferCommand.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Override the "equals" method in this class. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSQ3-GQEym9Vaoj2&open=AZ6opSQ3-GQEym9Vaoj2&pullRequest=12617

Check warning on line 423 in engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this if statement with the enclosing one. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSDk-GQEym9VaojW&open=AZ6opSDk-GQEym9VaojW&pullRequest=12617

Check failure on line 1295 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSXu-GQEym9Vaok1&open=AZ6opSXu-GQEym9Vaok1&pullRequest=12617

Check warning on line 2476 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Method has 8 parameters, which is greater than 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSXu-GQEym9Vaokv&open=AZ6opSXu-GQEym9Vaokv&pullRequest=12617

Check warning on line 899 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Update this method so that its implementation is not identical to "testHandleMissingDeviceNode_MethodExists" on line 889. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSek-GQEym9Vaol_&open=AZ6opSek-GQEym9Vaol_&pullRequest=12617

Check failure on line 320 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "--units" 3 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSWO-GQEym9VaokI&open=AZ6opSWO-GQEym9VaokI&pullRequest=12617

Check warning on line 901 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this hard-coded path-delimiter. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSWO-GQEym9Vaoki&open=AZ6opSWO-GQEym9Vaoki&pullRequest=12617

Check warning on line 2651 in server/src/test/java/com/cloud/storage/VolumeApiServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this and every subsequent useless "eq(...)" invocation; pass the values directly. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSuk-GQEym9Vaom4&open=AZ6opSuk-GQEym9Vaom4&pullRequest=12617

Check warning on line 61 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtModifyStoragePoolCommandWrapper.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this "Map.containsKey()" with a call to "Map.computeIfAbsent()". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSRQ-GQEym9Vaoj3&open=AZ6opSRQ-GQEym9Vaoj3&pullRequest=12617

Check failure on line 740 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSek-GQEym9Vaolw&open=AZ6opSek-GQEym9Vaolw&pullRequest=12617

Check warning on line 89 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPostMigrationCommandWrapperTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'org.libvirt.LibvirtException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSZ6-GQEym9VaolD&open=AZ6opSZ6-GQEym9VaolD&pullRequest=12617
View more details on SonarQubeCloud