fix(tui): load root sessions safely in dialogs#31132
Open
CasualDeveloper wants to merge 1 commit into
Open
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found a related PR: PR #26432:
The current PR (#31132) represents an improved/updated fix that builds upon the earlier approach in #26432. |
This was referenced Jun 6, 2026
Problem: Session dialogs built options from mixed or not-yet-loaded session data, which let child sessions crowd out roots and could freeze or stall an empty browse order during startup.\n\nSolution: Query root sessions from dialog-local resources, use synced root sessions while the browse request is pending, keep the selector mounted while loading, and share query/order helpers across both dialog implementations.\n\nNotes: Refs anomalyco#16270 and anomalyco#31125.
72d361b to
bdcc5ba
Compare
|
Yes please 👍 |
This was referenced Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #16270
Closes #31125
Partially addresses #13877
Supersedes #23276, #24383, #26432
Type of change
What does this PR do?
Problem: Session dialogs built options from mixed or not-yet-loaded session data, which let child sessions crowd out roots and could freeze an empty browse order during startup.
Solution:
How did you verify your code works?
bun test test/cli/tui/dialog-session-list.test.tsbun typecheckgit diff --checkbun turbo typecheckScreenshots / recordings
N/A. This changes session query/loading behavior, not the rendered layout.
Notes
Checklist