fix(@schematics/angular): safely comment out multiline statements in refactor-jasmine-vitest#33315
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a helper function addCommentedNodeText to safely comment out multi-line TypeScript AST nodes line-by-line, preventing syntax issues when converting them to single-line comments. This helper is integrated into several transformers (jasmine-lifecycle, jasmine-matcher, and jasmine-misc) and unit tests are added. The feedback suggests avoiding the inline require statement in the unit tests and instead using standard ES imports at the top of the file for consistency.
…refactor-jasmine-vitest When refactoring unsupported or empty statements (such as `pending()`, `expect().nothing()`, and certain `jasmine` member assignments), the schematic previously commented out the code using a single-line comment prefix on the full text of the node. If the statement spanned multiple lines, only the first line was commented, leaving subsequent lines uncommented. This resulted in invalid syntax or unexpected compile errors.
clydin
force-pushed
the
fix-jasmine-vitest-refactor-comments
branch
from
0fe72e1 to
f0b8109
Compare
clydin
added
the
action: review
alan-agius4
approved these changes
Jun 8, 2026
alan-agius4
added
action: merge
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When refactoring unsupported or empty statements (such as
pending(),expect().nothing(), and certainjasminemember assignments), the schematic previously commented out the code using a single-line comment prefix on the full text of the node. If the statement spanned multiple lines, only the first line was commented, leaving subsequent lines uncommented. This resulted in invalid syntax or unexpected compile errors.