Skip to content

Rename firebase FetchException to FirebaseConfigException#290

Merged
kirich1409 merged 1 commit into
developfrom
feature/289-rename-fetchexception
Jun 13, 2026
Merged

Rename firebase FetchException to FirebaseConfigException#290
kirich1409 merged 1 commit into
developfrom
feature/289-rename-fetchexception

Conversation

@kirich1409

@kirich1409 kirich1409 commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Summary

Renames the firebase provider's FetchExceptionFirebaseConfigException (closes #289).

Since #163, the exception wraps failures from both fetch() and initialize() (the latter calls ensureInitialized(), not a fetch), so the fetch-specific name no longer fits. The new name matches FirebaseConfigValueProvider and is operation-agnostic.

Changes (firebase module only)

  • FetchException.ktFirebaseConfigException.kt (git mv, history preserved); class renamed.
  • Class KDoc generalized: "Thrown when a Firebase Remote Config operation fails" — now covers initialize() and fetch().
  • Both throw sites + @throws / […] KDoc references in FirebaseConfigValueProvider.kt updated.
  • Test references and method names updated.

Pure rename — no behavioral change. ast-index usages "FetchException" returns empty.

Breaking change

FetchException is public API of the firebase provider. Per project policy (no migration window) the rename goes in directly; the version number reflects it.

:providers:firebase:compileDebugKotlin + testDebugUnitTest green; spotless clean.

🤖 Generated with Claude Code

Review in cubic

The exception wraps both fetch() and initialize() failures since #163,
so the fetch-specific name no longer fits. Pure rename, no behavior change.

Closes #289
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Re-trigger cubic

@kirich1409 kirich1409 merged commit 93fc761 into develop Jun 13, 2026
9 checks passed
@kirich1409 kirich1409 deleted the feature/289-rename-fetchexception branch June 13, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant