fix(pcie Issue#224): handle unknown PCIe capability IDs without crashing#225
Open
cijohnson wants to merge 1 commit into
Open
fix(pcie Issue#224): handle unknown PCIe capability IDs without crashing#225cijohnson wants to merge 1 commit into
cijohnson wants to merge 1 commit into
Conversation
The PCIe collector raised an unhandled ValueError when the config space exposed a capability ID not modeled in CapabilityEnum / ExtendedCapabilityEnum (e.g. 0x2F / IDE on MI300X), aborting the entire PCIe plugin run. - Add ExtendedCapabilityEnum.IDE = 0x2F (Integrity and Data Encryption) - Guard the enum conversion in get_cap_cfg so any unknown cap id is skipped with a warning instead of taking down the whole collection. Fixes amd#224 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PCIe collector raised an unhandled ValueError when the config space exposed a capability ID not modeled in CapabilityEnum / ExtendedCapabilityEnum (e.g. 0x2F / IDE on MI300X), aborting the entire PCIe plugin run.
Fixes #224
Summary
Test plan
pytest test/unitpytest test/functional(if applicable)pre-commit run --all-filesChecklist