Allow disabling MCP config filtering#207
Open
i1bro wants to merge 1 commit into
Open
Conversation
AlexandrSuhinin
requested changes
Jun 16, 2026
AlexandrSuhinin
left a comment
AlexandrSuhinin
left a comment
Collaborator
There was a problem hiding this comment.
Also we need a test for this.
| // Deduplicates new servers against existing config to prevent Codex from deep-merging | ||
| // incompatible field types (e.g., mixing url and stdio schemas). | ||
| const existingNames = await this.getConfigMcpServerNames(projectPath); | ||
| const existingNames = this.disableMcpConfigFiltering |
Collaborator
There was a problem hiding this comment.
I would create a single function shouldDeduplicateMcpConflicts() that will check for env variable or arg. And would avoid leaking it to constructor, field, etc.
| name: sanitizeMcpServerName(mcp.name), | ||
| server: mcp, | ||
| })); | ||
| const uniqueServers = requestedServers.filter(mcp => !existingNames.has(mcp.name)); |
Collaborator
There was a problem hiding this comment.
I would rather check it here, right where we filter mcp's to make the code explicit.
const uniqueServers ...
let mcpSevers ...
if (should deduplicate) {
filter
} else {
...
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.